Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bearer token visible in FlightSqlServiceClient #6253

Closed
ccciudatu opened this issue Aug 14, 2024 · 2 comments · Fixed by #6254
Closed

Make the bearer token visible in FlightSqlServiceClient #6253

ccciudatu opened this issue Aug 14, 2024 · 2 comments · Fixed by #6254
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Comments

@ccciudatu
Copy link
Contributor

FlightSqlServiceClient stores the bearer token it receives on the Handshake response and uses it on all subsequent requests. The Flight protocol does not clearly specify whether the bearer token has to be sent on DoGet calls as well (along with the ticket). Because of this, several Flight SQL server implementors decided to expect the bearer token on DoGet requests.
However, if the DoGet call needs to go to a different endpoint, or when the client decides to parallelise the streams and have the DoGet calls performed by different threads (or even nodes), the new client instances cannot access the bearer token simply because the field is private and only writable (set_ and clear_).

Adding a "getter" would solve this problem and allow the client app to propagate the token to distributed DoGet calls.

@ccciudatu ccciudatu changed the title Make the bearer token stored by the FlightSqlServiceClient visible Make the bearer token visible in FlightSqlServiceClient Aug 14, 2024
@alamb alamb added the arrow Changes to the arrow crate label Aug 31, 2024
@alamb
Copy link
Contributor

alamb commented Aug 31, 2024

label_issue.py automatically added labels {'arrow'} from #6254

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Aug 31, 2024
@alamb
Copy link
Contributor

alamb commented Aug 31, 2024

label_issue.py automatically added labels {'arrow-flight'} from #6254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants