Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for invalid parquet files #6261

Closed
alamb opened this issue Aug 15, 2024 · 1 comment · Fixed by #6262
Closed

Tests for invalid parquet files #6261

alamb opened this issue Aug 15, 2024 · 1 comment · Fixed by #6262
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Aug 15, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The https://github.com/apache/parquet-testing repo has several negative tests with invalid parquet data of various forms

We should make sure that the parquet-rs reader correctly errors on these files

Thanks to @mapleFU and @jp0317 🙏 for these files

Describe the solution you'd like
We should write a test that validates the reader correctly errors

Describe alternatives you've considered

Additional context
Here are some related tickets:

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Aug 15, 2024
@alamb alamb self-assigned this Aug 15, 2024
@alamb alamb changed the title Negative tests for invalid parquet files Tests for invalid parquet files Aug 15, 2024
@alamb alamb added the parquet Changes to the parquet crate label Aug 31, 2024
@alamb
Copy link
Contributor Author

alamb commented Aug 31, 2024

label_issue.py automatically added labels {'parquet'} from #6262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant