Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing schema metadata includes possibly incorrect compression level #6270

Closed
ttencate opened this issue Aug 19, 2024 · 1 comment · Fixed by #6271
Closed

Printing schema metadata includes possibly incorrect compression level #6270

ttencate opened this issue Aug 19, 2024 · 1 comment · Fixed by #6271
Labels
bug parquet Changes to the parquet crate

Comments

@ttencate
Copy link
Contributor

Describe the bug
print_parquet_metadata always reports ZSTD compression level 1, regardless of the level used when creating the file:

compression: ZSTD(ZstdLevel(1))

The cause is that the compression level is not actually stored anywhere. The value 1 is just the Default of ZstdLevel, needed to construct the Compression enum.

To Reproduce
Call print_parquet_metadata on a file using ZSTD compression using a non-default level. E.g. I used level 6.

Expected behavior

compression: ZSTD

Additional context
Discovered on manojkarthick/pqrs#53.

@ttencate ttencate added the bug label Aug 19, 2024
@alamb alamb added the parquet Changes to the parquet crate label Aug 31, 2024
@alamb
Copy link
Contributor

alamb commented Aug 31, 2024

label_issue.py automatically added labels {'parquet'} from #6271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants