Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object-store] Requested tokio version is too old - does not compile #6458

Closed
ashtuchkin opened this issue Sep 26, 2024 · 1 comment · Fixed by #6459
Closed

[object-store] Requested tokio version is too old - does not compile #6458

ashtuchkin opened this issue Sep 26, 2024 · 1 comment · Fixed by #6459
Labels
bug object-store Object Store Interface

Comments

@ashtuchkin
Copy link
Contributor

Describe the bug

Object store requests tokio="1.25.0" in it Cargo.toml, a pretty old version. If we have this version installed, it can't be compiled with the following error message:

error[E0624]: method `poll_join_next` is private
   --> /Systems/extlib/rust/object_store-0.11.0/src/upload.rs:155:31
    |
155 |             ready!(self.tasks.poll_join_next(cx)).unwrap()??
    |                               ^^^^^^^^^^^^^^ private method
    |
   ::: /Systems/extlib/rust/tokio-1.28.0/src/task/join_set.rs:365:5
    |
365 |     fn poll_join_next(&mut self, cx: &mut Context<'_>) -> Poll<Option<Result<T, JoinError>>> {
    |     ---------------------------------------------------------------------------------------- private method defined here

Naturally, poll_join_next was only made public in tokio 1.29.0 in this PR.

To Reproduce

Install tokio=1.25.0, object_store=0.11.0, observe the error message above when trying to compile.

Expected behavior

We should update tokio requirement to at least 1.29.0.

@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

label_issue.py automatically added labels {'object-store'} from #6459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants