Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DataType::Dictionary in make_builder within struct_builder.rs #6589

Closed
kszlim opened this issue Oct 19, 2024 · 3 comments · Fixed by #6593
Closed

Support DataType::Dictionary in make_builder within struct_builder.rs #6589

kszlim opened this issue Oct 19, 2024 · 3 comments · Fixed by #6593
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@kszlim
Copy link
Contributor

kszlim commented Oct 19, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Make it so that dictionary encoded sub-builders can be constructed from Fields.

Describe the solution you'd like
As described above

Describe alternatives you've considered
n/a

Additional context
I don't see any reason why it's unsupported besides it just not being feature complete yet.

@kszlim kszlim added the enhancement Any new improvement worthy of a entry in the changelog label Oct 19, 2024
@tustvold tustvold added good first issue Good for newcomers help wanted and removed good first issue Good for newcomers labels Oct 19, 2024
@tustvold
Copy link
Contributor

tustvold commented Oct 19, 2024

The challenge with dictionaries is the combinatorial explosion of possible types, we don't want to pay the codegen and consequently compile time costs for hundreds of different combinations of dictionary builder, when frankly very few of them make a whole lot of sense.

Might I suggest we just cover the cases with Int32 keys, and values of Utf8, LargeUtf8, Binary and LargeBinary.

@kszlim
Copy link
Contributor Author

kszlim commented Oct 20, 2024

@tustvold made the PR as you've suggested, feel free to make any edits you need (or i can do them).

@alamb alamb added the arrow Changes to the arrow crate label Oct 21, 2024
@alamb
Copy link
Contributor

alamb commented Oct 21, 2024

label_issue.py automatically added labels {'arrow'} from #6593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants