From 3e53811a08adda074747e24fccb27c9e75460808 Mon Sep 17 00:00:00 2001 From: kamille Date: Sat, 6 Jul 2024 12:40:34 +0800 Subject: [PATCH 1/3] allow rustdoc::unportable_markdown in arrow-flight. --- arrow-flight/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/arrow-flight/src/lib.rs b/arrow-flight/src/lib.rs index a4b4ab7bc31..325faad7df3 100644 --- a/arrow-flight/src/lib.rs +++ b/arrow-flight/src/lib.rs @@ -37,6 +37,7 @@ //! //! [Flight SQL]: https://arrow.apache.org/docs/format/FlightSql.html #![allow(rustdoc::invalid_html_tags)] +#![allow(rustdoc::unportable_markdown)] use arrow_ipc::{convert, writer, writer::EncodedData, writer::IpcWriteOptions}; use arrow_schema::{ArrowError, Schema}; From 16601ce4b41d0ac05bc4a9a26f4773e632cb0bfb Mon Sep 17 00:00:00 2001 From: kamille Date: Sat, 6 Jul 2024 12:43:01 +0800 Subject: [PATCH 2/3] fix doc in sql_info.rs. --- arrow-flight/src/sql/metadata/sql_info.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arrow-flight/src/sql/metadata/sql_info.rs b/arrow-flight/src/sql/metadata/sql_info.rs index d4584f4a682..97304d3c872 100644 --- a/arrow-flight/src/sql/metadata/sql_info.rs +++ b/arrow-flight/src/sql/metadata/sql_info.rs @@ -148,7 +148,7 @@ impl SqlInfoName for u32 { /// * int32_to_int32_list_map: map> /// * > /// ``` -///[flightsql]: (https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/format/FlightSql.proto#L32-L43 +///[flightsql]: https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/format/FlightSql.proto#L32-L43 ///[Union Spec]: https://arrow.apache.org/docs/format/Columnar.html#dense-union struct SqlInfoUnionBuilder { // Values for each child type @@ -361,7 +361,7 @@ impl SqlInfoDataBuilder { /// Encode the contents of this list according to the [FlightSQL spec] /// - /// [FlightSQL spec]: (https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/format/FlightSql.proto#L32-L43 + /// [FlightSQL spec]: https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/format/FlightSql.proto#L32-L43 pub fn build(self) -> Result { let mut name_builder = UInt32Builder::new(); let mut value_builder = SqlInfoUnionBuilder::new(); From 4ed3247570fca92e52437d45d59efbb6d397934b Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 6 Jul 2024 08:04:07 -0400 Subject: [PATCH 3/3] reduce scope of lint disable --- arrow-flight/src/lib.rs | 1 - arrow-flight/src/sql/mod.rs | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arrow-flight/src/lib.rs b/arrow-flight/src/lib.rs index 325faad7df3..a4b4ab7bc31 100644 --- a/arrow-flight/src/lib.rs +++ b/arrow-flight/src/lib.rs @@ -37,7 +37,6 @@ //! //! [Flight SQL]: https://arrow.apache.org/docs/format/FlightSql.html #![allow(rustdoc::invalid_html_tags)] -#![allow(rustdoc::unportable_markdown)] use arrow_ipc::{convert, writer, writer::EncodedData, writer::IpcWriteOptions}; use arrow_schema::{ArrowError, Schema}; diff --git a/arrow-flight/src/sql/mod.rs b/arrow-flight/src/sql/mod.rs index 089ee4dd8c3..b3b9882ee0f 100644 --- a/arrow-flight/src/sql/mod.rs +++ b/arrow-flight/src/sql/mod.rs @@ -45,6 +45,7 @@ use prost::Message; mod gen { #![allow(clippy::all)] + #![allow(rustdoc::unportable_markdown)] include!("arrow.flight.protocol.sql.rs"); }