Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] JDBC-to-Arrow Conversion: Unnecessary Calendar Requirement #20534

Closed
asfimport opened this issue Dec 1, 2018 · 2 comments
Closed

[Java] JDBC-to-Arrow Conversion: Unnecessary Calendar Requirement #20534

asfimport opened this issue Dec 1, 2018 · 2 comments

Comments

@asfimport
Copy link
Collaborator

While I was going through the JDBC Adapter source code, I noticed a Calendar was required to create the Arrow Schema (for any Timestamp fields), and also needed for converting a JDBC ResultSet to an ArrowVector (for Date, Time, and Timestamp fields).

However, Arrow Timestamps do not require a time zone, and none of the JDBC getters for Date, Time, and Timestamp require a Calendar.

I am proposing a change to make the Schema creator and ResultSet converter support null Calendars. If a Calendar is available, it will be used, and if not, it will not be used.

The existing SureFire plugin configuration uses a UTC calendar for the database, which is the default Calendar in the existing code.  Likewise, no changes to the unit tests are required to provide adequate coverage for the change.

Reporter: Michael Pigott / @mikepigott
Assignee: Michael Pigott / @mikepigott

PRs and other links:

Note: This issue was originally created as ARROW-3923. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Michael Pigott / @mikepigott:
Pull Request: #3066

@asfimport
Copy link
Collaborator Author

Uwe Korn / @xhochy:
Issue resolved by pull request 3066
#3066

@asfimport asfimport added this to the 0.13.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant