Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add support for system GFlags #21140

Closed
Tracked by #15952
asfimport opened this issue Feb 17, 2019 · 4 comments
Closed
Tracked by #15952

[C++] Add support for system GFlags #21140

asfimport opened this issue Feb 17, 2019 · 4 comments

Comments

@asfimport
Copy link
Collaborator

Reporter: Kouhei Sutou / @kou
Assignee: Kouhei Sutou / @kou

PRs and other links:

Note: This issue was originally created as ARROW-4599. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
Issue resolved by pull request 3675
#3675

@asfimport
Copy link
Collaborator Author

Francois Saint-Jacques / @fsaintjacques:
This has broken the build on linux with thirdparty gflags:

CMake Error at cmake_modules/ThirdpartyToolchain.cmake:658 (target_compile_definitions):
  Cannot specify compile definitions for imported target "gflags_static".
Call Stack (most recent call first):
  CMakeLists.txt:506 (include)

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
Could you open a new issue?
And please show your CMake version in the new issue.

@asfimport
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants