-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R package may be failing to compile on gcc13 #33635
Comments
Since gcc-13 isn't released yet, replicating this involves building gcc from source. I did so using this Dockerfile: FROM rocker/r-devel:latest
RUN apt update && apt install -y git flex
RUN git clone git://gcc.gnu.org/git/gcc.git gcc-dev
RUN cd gcc-dev && ./contrib/download_prerequisites
RUN mkdir gcc-build && cd gcc-build && ../gcc-dev/configure -disable-multilib --enable-languages=c,c++,fortran
RUN cd gcc-build && make -j4 && make install
RUN apt-get update && apt-get install -y cmake libssl-dev
RUN git clone https://github.com/apache/arrow.git /arrow && mkdir /arrow-build && cd /arrow-build && cmake /arrow/cpp -DCMAKE_C_COMPILER=/usr/local/bin/gcc -DCMAKE_CXX_COMPILER=/usr/local/bin/g++ -DARROW_CSV=ON -DARROW_DATASET=ON -DARROW_FILESYSTEM=ON -DARROW_COMPUTE=ON -DARROW_PARQUET=ON -DBoost_SOURCE=BUNDLED && cmake --build . && cmake --install . --prefix /arrow-dist
ENV ARROW_HOME /arrow-dist
RUN echo 'LD_LIBRARY_PATH="/arrow-dist/lib:/usr/local/lib64:${R_LD_LIBRARY_PATH}:${LD_LIBRARY_PATH}"' >> /usr/lib/R/etc/ldpaths
RUN mkdir ~/.R && echo 'CXX11=/usr/local/bin/g++' > ~/.R/Makevars && echo 'CXX14=/usr/local/bin/g++' >> ~/.R/Makevars && echo 'CXX17=/usr/local/bin/g++' >> ~/.R/Makevars && echo 'CXX=/usr/local/bin/g++' >> ~/.R/Makevars && echo 'CC=/usr/local/bin/gcc' >> ~/.R/Makevars
RUN echo 'CCFLAGS = -Wall -pedantic -O2' >> ~/.R/Makevars && echo 'CXXFLAGS = -Wall -pedantic -O2' >> ~/.R/Makevars && echo 'CXX11FLAGS = -Wall -pedantic -O2' >> ~/.R/Makevars
RUN R -e 'install.packages(c("testthat", "pkgbuild", "cpp11", "R6", "assertthat", "bit64", "bit", "cli", "ellipsis", "glue", "magrittr", "purrr", "rlang", "blob", "stringr", "tidyselect", "vctrs", "lubridate", "dplyr", "hms"))'
RUN cd /arrow/r && R CMD INSTALL .
CMD /bin/bash ...and was unable to replicate the error. @nealrichardson that should be sufficient to include to our "please hit reply-all and answer: have these problems been fixed"? The reported error seemed to indicate that the error might be a result of a compiler bug (which may have been fixed between the time that BDR built gcc13 and when I built gcc13 today). |
Did you try to reproduce with the current release or latest master? Maybe something else we did in arrow since the last release fixed it? "Works on my machine" doesn't typically work but if that's all we have, I guess we'll have to give it a shot. Thanks for trying to reproduce. |
https://cran.r-project.org/web/checks/check_results_arrow.html no longer shows a gcc13 issue, so perhaps BDR rebuilt latest and the issue resolved. |
Describe the bug, including details regarding any error messages, version, and platform.
We'll need to fix all warnings shown on the package check page before the CRAN release. One of those is a gcc13 warning/error (unclear which). We used to have a job that did gcc12 and should try to update that to do gcc13.
https://cran.r-project.org/web/checks/check_results_arrow.html
Verbose error bits (with apologies for the ANSI):
Component(s)
R
The text was updated successfully, but these errors were encountered: