Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Bundled OpenTelemetry build is broken #36013

Closed
bkietz opened this issue Jun 9, 2023 · 1 comment · Fixed by #36016
Closed

[C++] Bundled OpenTelemetry build is broken #36013

bkietz opened this issue Jun 9, 2023 · 1 comment · Fixed by #36016
Assignees
@bkietz
Labels
Component: C++ Type: bug
Milestone
13.0.0

Comments

@bkietz
Copy link
Member

bkietz commented Jun 9, 2023

Describe the bug, including details regarding any error messages, version, and platform.

OpenTelemetry and Protobuf have conflicting versions of Abseil, which is causing build errors

These issues have been encountered and addressed in the conda-forge feedstock for opentelemetry, see

Unfortunately, the fix requires a patch to OpenTelemetry so it's not as simple as building -D WITH_STL=ON.

For now it should be sufficient to disable bundled OpenTelemetry and rely on conda-forge's patch.

@kou @lidavidm

Component(s)

C++
bkietz added a commit to bkietz/arrow that referenced this issue Jun 9, 2023
@bkietz
apacheGH-36013: [C++] disabling bundled opentelemetry
7224c33
@github-actions github-actions bot mentioned this issue Jun 9, 2023
Merged
@kou
Copy link
Member

kou commented Jun 9, 2023

open-telemetry/opentelemetry-cpp#2163 may fix this.

This may not be happen when we use Protobuf < 3.22?

@js8544 js8544 mentioned this issue Jun 15, 2023
Closed
kou pushed a commit that referenced this issue Jun 16, 2023
@bkietz
GH-36013: [C++] Disabling bundled OpenTelemetry with Protobuf 3.22+ (#…
41309de 
…36016)

OpenTelemetry and Protobuf 3.22+ have conflicting versions of Abseil, which is causing build errors. This patch disables OpenTelemetry on macOS because Homebrew provides Protobuf 3.22+.
* Closes: #36013

Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jun 16, 2023
@kou kou mentioned this issue Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkietz bkietz

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36013: [C++] Disabling bundled OpenTelemetry with Protobuf 3.22+ bkietz/arrow
2 participants
@kou @bkietz