-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36809: [Python] MapScalar.as_py with custom field name #36830
GH-36809: [Python] MapScalar.as_py with custom field name #36830
Conversation
|
…scalar-as-py-with-custom-field-name
Could you revert updating submodules? |
I agree, I didn't intend to do that. Do you know which git command I need to run to revert them? |
The following command lines will work: cd cpp/submodules/parquet-testing
git checkout b2e7cc755159196e3a068c8594f7acbaecfdaaac
cd -
cd testing
git checkout 47f7b56b25683202c1fd957668e13f2abafc0f12
cd -
git add cpp/submodules/parquet-testing testing
git commit
git push |
That worked, thanks 👍 |
…scalar-as-py-with-custom-field-name
@kou do you mind reviewing again? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 52ac718. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
…he#36830) ### Rationale for this change `MapScalar.as_py` doesn't take into account custom key/value field names ### What changes are included in this PR? Fix and tests ### Are these changes tested? Simple unit test ### Are there any user-facing changes? No API changes. * Closes: apache#36809 Authored-by: aandres <aandres@tradewelltech.co> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…he#36830) ### Rationale for this change `MapScalar.as_py` doesn't take into account custom key/value field names ### What changes are included in this PR? Fix and tests ### Are these changes tested? Simple unit test ### Are there any user-facing changes? No API changes. * Closes: apache#36809 Authored-by: aandres <aandres@tradewelltech.co> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
MapScalar.as_py
doesn't take into account custom key/value field namesWhat changes are included in this PR?
Fix and tests
Are these changes tested?
Simple unit test
Are there any user-facing changes?
No API changes.