Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39196: [Python][Docs] Document the Arrow PyCapsule protocol in the 'extending pyarrow' section of the Python docs #39199

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 12, 2023

Rationale for this change

While the Arrow PyCapsule protocol itself is defined in the specification part of the docs, this PR adds a section about it in the Python user guide as well (referring to the specification for most details), where users might typically look for Python specific docs.

@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review December 12, 2023 12:51
docs/source/python/extending_types.rst Outdated Show resolved Hide resolved
docs/source/python/extending_types.rst Outdated Show resolved Hide resolved
docs/source/python/extending_types.rst Outdated Show resolved Hide resolved
@jorisvandenbossche jorisvandenbossche changed the title [Python][Docs] Document the Arrow PyCapsule protocol in the 'extending pyarrow' section of the Python docs GH-39196: [Python][Docs] Document the Arrow PyCapsule protocol in the 'extending pyarrow' section of the Python docs Dec 12, 2023
@apache apache deleted a comment from github-actions bot Dec 12, 2023
Copy link

⚠️ GitHub issue #39196 has been automatically assigned in GitHub to PR creator.

jorisvandenbossche and others added 2 commits December 12, 2023 13:55
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@jorisvandenbossche jorisvandenbossche merged commit 2f9f892 into apache:main Dec 21, 2023
6 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Dec 21, 2023
@jorisvandenbossche jorisvandenbossche deleted the gh-39196-pycapsule-docs branch December 21, 2023 14:53
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2f9f892.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…in the 'extending pyarrow' section of the Python docs (apache#39199)

### Rationale for this change

While the Arrow PyCapsule protocol itself is defined in the specification part of the docs, this PR adds a section about it in the Python user guide as well (referring to the specification for most details), where users might typically look for Python specific docs.
* Closes: apache#39196

Lead-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…in the 'extending pyarrow' section of the Python docs (apache#39199)

### Rationale for this change

While the Arrow PyCapsule protocol itself is defined in the specification part of the docs, this PR adds a section about it in the Python user guide as well (referring to the specification for most details), where users might typically look for Python specific docs.
* Closes: apache#39196

Lead-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python][Docs] Document the PyCapsule protocol in the "extending pyarrow" section of the Python docs
2 participants