-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Java] Bump com.google.protobuf:protobuf-bom from 3.25.1 to 4.26.1 in /java #41442
MINOR: [Java] Bump com.google.protobuf:protobuf-bom from 3.25.1 to 4.26.1 in /java #41442
Conversation
@danepitkin seems like this needs some additional work [1]. Should we pursue this and make a separate PR? |
Maybe. Since its a major version upgrade, I'd be curious to know what backwards-breaking changes are introduced (assuming they are using semver) and if there are any compatibility issues with other arrow implementations. I don't think this is high priority because Java protobuf 3.25.X has support until 2025 (see https://protobuf.dev/support/version-support/). |
Ah, looks like we will have to regenerate protobuf classes: https://protobuf.dev/news/2023-12-05/
|
We don't check in generated sources. Also, the error is unrelated to Protobuf. It's ErrorProne with a new error. |
@lidavidm I think the linting changes need to be integrated first, then we could minimize the error-prone in the process? |
I think we can fix the problem error-prone is indicating here? |
I will check. |
Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.1 to 4.26.1. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-bom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
b94f93d
to
a0bc5c5
Compare
Superseded by #41854. |
Bumps com.google.protobuf:protobuf-bom from 3.25.1 to 4.26.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)