Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Support STRING_VIEW and BINARY_VIEW in "array_take" and "array_filter" functions #43010

Open
felipecrv opened this issue Jun 22, 2024 · 2 comments

Comments

@felipecrv
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Kernels for Type::STRING_VIEW/BINARY_VIEW are missing.

Component(s)

C++

@mapleFU
Copy link
Member

mapleFU commented Jul 17, 2024

@felipecrv Hi if you're busy, I may take time to do this, since during testing read/write utf8 it's better to having some useful tools. I may not familiar with compute but I'd like to have a try

@felipecrv
Copy link
Contributor Author

@mapleFU you can go ahead and make a simple implementation (similar to the one for strings), but note that I'm about to merge #41700 which moves a lot of stuff around take and filter while also introducing ways of implementing more efficient take kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants