-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36013: [C++] Disabling bundled OpenTelemetry with Protobuf 3.22+ #36016
Conversation
|
LGTM, I think the macOS issue is #35987 |
We may not need to disable OpenTelemetry for Feodra 35, Ubuntu 20.04 and Ubuntu 22.04 because they use Protobuf < 3.22. They weren't failed in our nightly CI: https://lists.apache.org/thread/yoq1zstmq5fpcg2kxw811pmlq0f8qnvn |
Hmm, and there's still a link failure in macOS https://github.com/apache/arrow/actions/runs/5225374020/jobs/9434755803?pr=36016#step:9:1546 |
The failure is #35987 as David said. It's not related to this. |
@github-actions crossbow submit test-fedora-35-cpp |
Revision: 58c073a Submitted crossbow builds: ursacomputing/crossbow @ actions-df4ae3fe29
|
The Fedora 35 job passed. |
@github-actions crossbow submit test-ubuntu-*-cpp |
Revision: bdfba60 Submitted crossbow builds: ursacomputing/crossbow @ actions-3f91702e2f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Conbench analyzed the 6 benchmark runs on commit There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. |
OpenTelemetry and Protobuf 3.22+ have conflicting versions of Abseil, which is causing build errors. This patch disables OpenTelemetry on macOS because Homebrew provides Protobuf 3.22+.