GH-37657: [JS] Run bin scripts with ts-node #38500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to use ts-node in transpile-only mode, fix tsc errors in bin scripts
assignUser
requested review from
kou,
raulcd,
domoritz and
trxcllnt
as code owners
|
As @domoritz has already approved these changes I will merge this on monday if there are no objections. |
domoritz
approved these changes
Oct 28, 2023
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d8aeb42. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
(rebased version of apache#37668, yarn.lock conflicts resolved in favor of main) * update bin scripts to use ts-node in transpile-only mode * remove ts-node config from top level tsconfig.json * fix tsc errors in bin scripts * Closes: apache#37657 Authored-by: ptaylor <paul.e.taylor@me.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
(rebased version of apache#37668, yarn.lock conflicts resolved in favor of main) * update bin scripts to use ts-node in transpile-only mode * remove ts-node config from top level tsconfig.json * fix tsc errors in bin scripts * Closes: apache#37657 Authored-by: ptaylor <paul.e.taylor@me.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(rebased version of #37668, yarn.lock conflicts resolved in favor of main)