From 9efd46ae7b748f2b8788b3ed0f46d4d6f70518a7 Mon Sep 17 00:00:00 2001 From: Ahmed Abualsaud Date: Wed, 25 Sep 2024 19:40:45 -0400 Subject: [PATCH] fix some tests --- .../test/java/org/apache/beam/sdk/util/RowFilterTest.java | 4 ++-- .../apache/beam/sdk/util/RowStringInterpolatorTest.java | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowFilterTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowFilterTest.java index 22c17f6d07c99..93ee9cedb472e 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowFilterTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowFilterTest.java @@ -254,7 +254,7 @@ public void testKeepSchemaFields() { @Test public void testDropNestedFieldsFails() { thrown.expect(IllegalArgumentException.class); - thrown.expectMessage("RowFilter does not support specifying nested fields to drop"); + thrown.expectMessage("'drop' does not support nested fields"); new RowFilter(ROW_SCHEMA) .dropping( @@ -270,7 +270,7 @@ public void testDropNestedFieldsFails() { @Test public void testKeepNestedFieldsFails() { thrown.expect(IllegalArgumentException.class); - thrown.expectMessage("RowFilter does not support specifying nested fields to keep"); + thrown.expectMessage("'keep' does not support nested fields"); new RowFilter(ROW_SCHEMA) .keeping( diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowStringInterpolatorTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowStringInterpolatorTest.java index 46804548a57fd..23fd740ac770f 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowStringInterpolatorTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowStringInterpolatorTest.java @@ -69,7 +69,9 @@ public void testInvalidRowThrowsHelpfulError() { thrown.expect(IllegalArgumentException.class); thrown.expectMessage("Invalid row does not contain field 'str'."); - interpolator.interpolate(ValueInSingleWindow.of(invalidRow, null, null, null)); + interpolator.interpolate( + ValueInSingleWindow.of( + invalidRow, new Instant(0), GlobalWindow.INSTANCE, PaneInfo.NO_FIRING)); } @Test @@ -156,7 +158,9 @@ public void testDoublyNestedInterpolation() { "foo {str}, bar {row.nested_row.doubly_nested_str}, baz {row.nested_row.doubly_nested_int}"; RowStringInterpolator interpolator = new RowStringInterpolator(template, ROW_SCHEMA); - String output = interpolator.interpolate(ValueInSingleWindow.of(ROW, null, null, null)); + String output = + interpolator.interpolate( + ValueInSingleWindow.of(ROW, new Instant(0), GlobalWindow.INSTANCE, PaneInfo.NO_FIRING)); assertEquals("foo str_value, bar doubly_nested_str_value, baz 789", output); }