From ca3436c504a1dac7e4f8e14b8e46f473e03c9f51 Mon Sep 17 00:00:00 2001 From: Alexey Romanenko Date: Fri, 6 Apr 2018 11:24:01 +0200 Subject: [PATCH] [BEAM-2852] Fix minor code style issues --- .../org/apache/beam/sdk/nexmark/NexmarkLauncher.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java b/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java index 172bdc26bfd8a..cd24897664acf 100644 --- a/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java +++ b/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java @@ -820,18 +820,17 @@ public void processElement(ProcessContext c) { private PCollection sourceEventsFromKafka(Pipeline p) { NexmarkUtils.console("Reading events from Kafka Topic %s", options.getKafkaSourceTopic()); - if (Strings.isNullOrEmpty(options.getBootstrapServers())) { - throw new RuntimeException("Missing --bootstrapServers"); - } + checkArgument(!Strings.isNullOrEmpty(options.getBootstrapServers()), + "Missing --bootstrapServers"); - KafkaIO.Read io = KafkaIO.read() + KafkaIO.Read read = KafkaIO.read() .withBootstrapServers(options.getBootstrapServers()) .withTopic(options.getKafkaSourceTopic()) .withKeyDeserializer(LongDeserializer.class) .withValueDeserializer(ByteArrayDeserializer.class); return p - .apply(queryName + ".ReadKafkaEvents", io.withoutMetadata()) + .apply(queryName + ".ReadKafkaEvents", read.withoutMetadata()) .apply(queryName + ".KafkaToEvents", ParDo.of(BYTEARRAY_TO_EVENT)); }