Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate beam_it_args -> beam_it_options #18434

Closed
kennknowles opened this issue Jun 3, 2022 · 0 comments
Closed

migrate beam_it_args -> beam_it_options #18434

kennknowles opened this issue Jun 3, 2022 · 0 comments

Comments

@kennknowles
Copy link
Member

When adding the mvn -> pkb -> mvn integration for the IO IT's usage of PKB, I noticed that beam_it_args had two problems:

  1. args had a format for passing options that was sub-optimal
  2. the thing we are working with is options, not args, so it's mis-named.

It was important to solve #1, but you can't just change the name since it'd break with the currently checked in jenkins job. So I needed to migrate away from it, and #2 presented an easy opportunity to do so, so I added beam_it_options as the new option.

We should remove usages of beam_it_args and migrate over to only beam_it_options, then remove beam_it_args from pkb

Imported from Jira BEAM-2650. Original Jira may contain additional context.
Reported by: sisk.

@damccorm damccorm added tests and removed testing labels Jun 16, 2022
@Abacn Abacn closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants