Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Remove upper bound on google-cloud-profiler once TensorFlow supports Protobuf 4.x #23355

Closed
AnandInguva opened this issue Sep 23, 2022 · 5 comments · Fixed by #24599
Closed

[Task]: Remove upper bound on google-cloud-profiler once TensorFlow supports Protobuf 4.x #23355

AnandInguva opened this issue Sep 23, 2022 · 5 comments · Fixed by #24599
Assignees
@AnandInguva
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python task
Milestone
2.47.0 Release

Comments

@AnandInguva
Copy link
Contributor

AnandInguva commented Sep 23, 2022 •
edited
Loading

What needs to happen?

Tensorflow 2.11.0 won't have upper bound on Protobuf and then Protbuf can be updated in the Apache Beam. Once we update Protobuf, we can remove upper bound restriction on google-cloud-profiler

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core
@AnandInguva AnandInguva mentioned this issue Sep 23, 2022
Merged
4 tasks
@tvalentyn tvalentyn added this to the 2.43.0 Release milestone Sep 27, 2022
@chamikaramj
Copy link
Contributor

Moving this to next milestone since Tensorflow 2.11 has not been released yet.

@kennknowles
Copy link
Member

@tvalentyn @damccorm @AnandInguva Tensorflow 2.11.0 is released. Has this follow-up been completed? Is it critical for 2.44.0? Can you get it in ASAP if so?

@damccorm
Copy link
Contributor

damccorm commented Dec 1, 2022

I don't think this should be a release blocker and I don't think its actively being worked on. @tvalentyn feel free to disagree and add back the blocker, otherwise I'm removing the milestone.

Tensorflow 2.11 has now been released so we can do this.

@damccorm damccorm removed this from the 2.44.0 Release milestone Dec 1, 2022
@AnandInguva
Copy link
Contributor Author

Tensorflow 2.11 pushed back on protobuf upper bound. They are still using 3.x.x protobuf.

https://github.com/tensorflow/tensorflow/blob/d5b57ca93e506df258271ea00fc29cf98383a374/tensorflow/tools/pip_package/setup.py#L102

@AnandInguva AnandInguva changed the title [Task]: Remove upper bound on google-cloud-profiler once TensorFlow 2.11 releases [Task]: Remove upper bound on google-cloud-profiler once TensorFlow supports Protobuf 4.x Dec 8, 2022
@AnandInguva
Copy link
Contributor Author

We can still keep this as a tracking issue and circle back to this in the coming releases.

@Abacn Abacn mentioned this issue Dec 21, 2022
Closed
@AnandInguva AnandInguva mentioned this issue Feb 17, 2023
Merged
3 tasks
@github-actions github-actions bot added this to the 2.47.0 Release milestone Mar 15, 2023
@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnandInguva AnandInguva

Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python task
Projects
None yet
Milestone
2.47.0 Release
Development

Successfully merging a pull request may close this issue.

Update Protobuf and GCP dependencies in Beam Python SDK AnandInguva/beam
5 participants
@kennknowles @tvalentyn @chamikaramj @AnandInguva @damccorm