-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit six dependency #24432
Comments
Error is:
|
Looks like its succeeding on mac, but failing on windows/linux |
This happens because of Comparing passing build vs failing build, six is not getting installed in the failing build during this step. May be one of the dependencies might have removed six as transitive dep? I will dig more. |
For the passing build, I will raise a PR to pin the grpcio version to 1.50.0 or better, we could install six without pinning version on grpcio |
Reopening since we should eventually remove this dependency entirely when the problem is fixed upstream per @AnandInguva |
was the issue reported upstream? |
mypy-protobuf 2.0 removed the dependency on six[1] but in our build we install mypy-protobuf==1.18 which depends on six. six was installed as a transitive dependency of grpcio-tools==1.37.0 --> grpcio==1.50.0 --> six but yesterday grpcio new version has been released and it doesn't depend on six. So, for a more concrete fix we should update |
This can be picked up during fixit week. |
What happened?
Python tests have been failing on master for the last 18 hours - https://github.com/apache/beam/actions/workflows/python_tests.yml?query=branch%3Amaster - usually on the wordcount tests
Example link: https://github.com/apache/beam/actions/runs/3579807043
Looks like the first failure is https://github.com/apache/beam/actions/runs/3578786077
Issue Failure
Failure: Test is continually failing
Issue Priority
Priority: 1
Issue Component
Component: sdk-py-core
The text was updated successfully, but these errors were encountered: