Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: adapt to protobuf versioning #26043

Closed
1 of 15 tasks
cdeepali opened this issue Mar 30, 2023 · 2 comments
Closed
1 of 15 tasks

[Bug]: adapt to protobuf versioning #26043

cdeepali opened this issue Mar 30, 2023 · 2 comments
Labels
awaiting triage bug done & done Issue has been reviewed after it was closed for verification, followups, etc. P3 python

Comments

@cdeepali
Copy link

What happened?

protubuf has adopted a new versioning scheme announced at https://protobuf.dev/news/2022-05-06/#versioning.

As taken from protocolbuffers/protobuf#12062 (comment):

- C++ protobuf releases version numbered {major}.{minor}
- Python protobuf adds 4. prefix to the versions (so git tag v21.12 becomes [4.21.12](https://pypi.org/project/protobuf/4.21.12/) on pypi).
- Java add 3. prefix to the versions (hence git tag v21.12 becomes [3.21.12](https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java/3.21.12).

So looks like there is a need to allow protobuf v4 at https://github.com/apache/beam/blob/v2.43.0/sdks/python/setup.py#L191

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@AnandInguva
Copy link
Contributor

AnandInguva commented Mar 30, 2023

Protobuf was recently updated to 4.x.x at #24599. That change will be included in Beam 2.47.0.

'protobuf>=4.21.1,<4.23.0',

@cdeepali
Copy link
Author

Thanks @AnandInguva.

@github-actions github-actions bot added this to the 2.47.0 Release milestone Mar 31, 2023
@damccorm damccorm added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage bug done & done Issue has been reviewed after it was closed for verification, followups, etc. P3 python
Projects
None yet
Development

No branches or pull requests

3 participants