Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Upgrade to Gradle 8 #28127

Closed
1 of 15 tasks
Abacn opened this issue Aug 23, 2023 · 2 comments · Fixed by #28756
Closed
1 of 15 tasks

[Feature Request]: Upgrade to Gradle 8 #28127

Abacn opened this issue Aug 23, 2023 · 2 comments · Fixed by #28756

Comments

@Abacn
Copy link
Contributor

Abacn commented Aug 23, 2023

What would you like to happen?

So far, the latest gradle supports up to Java 20. As Java 21 support is planned, this would require gradle at least > 8.

Blocks #28120

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor Author

Abacn commented Aug 23, 2023

Note that we currently see warning messages like

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

very often during a build. So this task requires identify and fix those deprecated gradle features

Known deprecation:

Configure project :sdks:java:core
The org.gradle.util.ClosureBackedAction type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/7.6.2/userguide/upgrading_version_7.html#org_gradle_util_reports_deprecations
at build_3ncpxweerxmaf7xb8tj1p0f5c.run(/Users/yathu/beam/sdks/java/core/build.gradle:20)
(Run with --stacktrace to get the full stack trace of this deprecation warning.)

Task :model:pipeline:generateProto
Relying on FileTrees for ignoring empty directories when using @SkipWhenEmpty has been deprecated. This is scheduled to be removed in Gradle 8.0. Annotate the property sourceFiles with @IgnoreEmptyDirectories or remove @SkipWhenEmpty. Consult the upgrading guide for further information: https://docs.gradle.org/7.6.2/userguide/upgrading_version_7.html#empty_directories_file_tree

@Abacn Abacn self-assigned this Sep 29, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Sep 29, 2023

com.palantir.docker plugin used in applyDockerNature is defunct on gradle 8, and the plugin won't get updated: palantir/gradle-docker#573

Currently beam uses v0.34 for this plugin; update to 0.35.0 showing the error:

com/palantir/gradle/docker/DockerComponent has been compiled by a more recent version of the Java Runtime
(class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

the 0.35.0 version was compiled on Java 11, which is no longer compatible with Beam.

This currently blocks Gradle 8 upgrade for beam. We have to migrate off from this plugin.

@Abacn Abacn mentioned this issue Sep 30, 2023
3 tasks
@github-actions github-actions bot added this to the 2.52.0 Release milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant