Avoid length-prefix-bytes substitutions for Flink boundaries. #31579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runner infrastructure typically substitutes "unknown" coders for length-prefixed bytes, but for elements going into or out of the Beam pipeline fragment we want the actual objects. Fortunately, we know these coders are known on the Runner side as well as the SDK side as we have them in hand there.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Ready for review ? |
|
Yes, this is ready for review. Would you be willing to take a look. |
|
R: @kennknowles |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
kennknowles
approved these changes
Jul 9, 2024
Polber
pushed a commit
to Polber/beam
that referenced
this pull request
Jul 9, 2024
…ns for Flink boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner infrastructure typically substitutes "unknown" coders for length-prefixed bytes, but for elements going into or out of the Beam pipeline fragment we want the actual objects. Fortunately, we know these coders are known on the Runner side as well as the SDK side as we have them in hand there.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.