Add Storage API streaming max retries parameter for BigQueryOptions

[Amar3tto]

Fixes #25382

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[Amar3tto]

R: @Abacn

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[Abacn]

multiple band-aid fix has made the retry behavior more complicated. Specifically, for batch job, the max retry number is not longer to be 500

#26503 - fail the work item after retry 5 times, in StorageApiWriteUnshardedRecords, this is for batch

#31253 - retry 10 times (instead of 5) for quota error

and this change works for streaming (which uses StorageApiWritesShardedRecords or StorageApiWriteRecordsInconsistent)

Let's update the description mention that this is only for streaming, or update to make it also work with batch (but need more care, batch and streaming currently have different default)

[Amar3tto]

Run Java_GCP_IO_Direct PreCommit

[Amar3tto]

multiple band-aid fix has made the retry behavior more complicated. Specifically, for batch job, the max retry number is not longer to be 500

#26503 - fail the work item after retry 5 times, in StorageApiWriteUnshardedRecords, this is for batch

#31253 - retry 10 times (instead of 5) for quota error

and this change works for streaming (which uses StorageApiWritesShardedRecords or StorageApiWriteRecordsInconsistent)

Let's update the description mention that this is only for streaming, or update to make it also work with batch (but need more care, batch and streaming currently have different default)

I renamed the parameter and description

[Abacn]

thanks.

When we come back to the batch pipeline retry it's good to not introducing another pipeline option. How about keep getStorageWriteApiMaxRetries naming and in the description noting that currently it is only applicable for streaming pipeline?

Or noting in javadoc that this opition is experimental and could change?

[Amar3tto]

thanks.

When we come back to the batch pipeline retry it's good to not introducing another pipeline option. How about keep getStorageWriteApiMaxRetries naming and in the description noting that currently it is only applicable for streaming pipeline?

Or noting in javadoc that this opition is experimental and could change?

Agree, fixed