Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom JdbcReadWithPartitionsHelper for Jdbc.ReadWithPartitions #31702

Closed
wants to merge 1 commit into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jun 27, 2024

Fix #31419

String sorting is more complex than integers / datetimes (the field can be alpha-numeric; base64; alphabetic; etc, and other scenarios). The solution here is to support custom JdbcReadWithPartitionsHelper.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Jun 27, 2024

In fact, the original implementation #15848 entitled "An any-type implementation for readWithPartitions". It pretty much provided the interface to support any-type for readWithPartitions, but not exposed JdbcReadWithPartitionsHelper as public API.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Jul 1, 2024

R: @Amar3tto

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

JdbcUtil.PRESET_HELPERS.keySet());
JdbcReadWithPartitionsHelper<PartitionColumnT> helper =
MoreObjects.firstNonNull(
getPartitionHelper(), JdbcUtil.getDefaultPartitionsHelper(getPartitionColumnType()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we losing the "readWithPartitions only supports the following types: %s" message if there is no custom helper and type is not supported?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think partitionColumnType is not a required parameter if custom partitionsHelper is passed. Maybe implement something like this?

@Abacn Abacn closed this Jul 2, 2024
@Abacn Abacn deleted the custompartition branch July 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using string in PartitionColumn throws error, tries to convert it to string
2 participants