Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solace Read connector: Use ByteBuffer instead of BytesString in the Record class #31746

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

bzablocki
Copy link
Contributor

@bzablocki bzablocki commented Jul 2, 2024

Beam Schemas don't support ByteString types. The pipeline was throwing the following exception in runtime:

    SEVERE: Error occurred within org.apache.beam.runners.direct.DirectTransformExecutor@3df140ba
    java.lang.VerifyError: Bad type on operand stack
    Exception Details:
      Location:
        org/apache/beam/sdk/io/solace/data/SchemaUserTypeCreator$SchemaCodeGen$uTIIUHuv.create([Ljava/lang/Object;)Ljava/lang/Object; @90: invokevirtual
      Reason:
        Type 'java/lang/Iterable' (current frame, stack[2]) is not assignable to 'org/apache/beam/vendor/grpc/v1p60p1/com/google/protobuf/ByteString'
      Current Frame:
        bci: @90
        flags: { }
        locals: { 'org/apache/beam/sdk/io/solace/data/SchemaUserTypeCreator$SchemaCodeGen$uTIIUHuv', '[Ljava/lang/Object;' }
        stack: { 'org/apache/beam/sdk/io/solace/data/AutoValue_Solace_Record$Builder', 'org/apache/beam/sdk/io/solace/data/AutoValue_Solace_Record$Builder', 'java/lang/Iterable' }

I changed the field type to BufferString, which is supported by the Schemas.
(addresses #31440).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@bzablocki
Copy link
Contributor Author

Run Java PreCommit

@bzablocki
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@m-trieu m-trieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzablocki
Copy link
Contributor Author

Thank you @m-trieu ! Is it ready to merge or are we waiting for another LGTM?

@Abacn Abacn merged commit f15ca98 into apache:master Jul 3, 2024
22 checks passed
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants