Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Dataflow service API version. #31751

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

acrites
Copy link
Contributor

@acrites acrites commented Jul 2, 2024

Updates which version of the Dataflow service API to use.

@damondouglas


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jul 2, 2024
@damondouglas damondouglas self-requested a review July 2, 2024 17:48
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal tests passed. Additionally, there is no special note for version setting as follows, indicating can update on its own:

  • // [bomupgrader] sets version
  • // google_cloud_platform_libraries_bom sets version

@damondouglas damondouglas merged commit 8a4a250 into apache:master Jul 2, 2024
21 checks passed
@acrites acrites deleted the beam-plugin branch July 2, 2024 20:52
@Abacn
Copy link
Contributor

Abacn commented Jul 2, 2024

Internal tests passed. Additionally, there is no special note for version setting as follows, indicating can update on its own:

  • // [bomupgrader] sets version
  • // google_cloud_platform_libraries_bom sets version

I tried to do this and found that that gcp-bom does not manage "com.google.apis:google-api-services-dataflow" version directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants