Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: KafkaIO maintains duplicate caches for record size and offset estimators caches #33097

Closed
2 of 17 tasks
sjvanrossum opened this issue Nov 13, 2024 · 4 comments
Closed
2 of 17 tasks

Comments

@sjvanrossum
Copy link
Contributor

What happened?

Offset consumers are created and cached for every KafkaSourceDescriptor processed per ReadFromKafkaDoFn instance. Caching multiple open Kafka consumers for the same KafkaSourceDescriptor is expensive both on the client and server side and may exhaust connection limits on some Kafka clusters.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@sjvanrossum
Copy link
Contributor Author

sjvanrossum commented Nov 13, 2024

Fix provided in #32928.

@github-actions github-actions bot added this to the 2.61.0 Release milestone Nov 13, 2024
@sjvanrossum sjvanrossum reopened this Nov 13, 2024
@damccorm
Copy link
Contributor

@sjvanrossum it looks like automation added this to the 2.61.0 release, is it actually a release blocker?

@sjvanrossum
Copy link
Contributor Author

@damccorm it's not a hard blocker, but since #32928 was approved last week (pending merge of #32921, now merged) I figured I'd flag it on the milestone for your awareness in case you'd like to see it included in 2.61.0.

@damccorm
Copy link
Contributor

Closing since #32928 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants