Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Clean up Typescript Tests workflow #33344

Open
damondouglas opened this issue Dec 10, 2024 · 1 comment
Open

[Task]: Clean up Typescript Tests workflow #33344

damondouglas opened this issue Dec 10, 2024 · 1 comment
Assignees
@damondouglas
Labels
P2 task

Comments

@damondouglas
Copy link
Contributor

damondouglas commented Dec 10, 2024 •
edited
Loading

What needs to happen?

.github/workflows/typescript_tests.yml contains an Authenticate on GCP step that uses google-github-actions/auth@v1. Said step provides Google Cloud authentication using an outdated static credential pattern and can be removed. Notably the xlang and Dataflow tests have been broken for months. Removing the step could fix the Dataflow tests, though not the xlang Tests. See #33346 for a bug report about the xlang Tests.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)
@damondouglas damondouglas self-assigned this Dec 10, 2024
@damondouglas damondouglas changed the title [Task]: [Task]: Remove static GCP credentials from Typescript Tests Dec 10, 2024
@github-actions github-actions bot added the P2 label Dec 10, 2024
@damondouglas damondouglas changed the title [Task]: Remove static GCP credentials from Typescript Tests [Task]: Clean up Typescript Tests workflow Dec 12, 2024
@damondouglas
Copy link
Contributor Author

damondouglas commented Dec 12, 2024 •
edited
Loading

Waiting for #33354 approval/merge before addressing this issue as it will follow the same strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damondouglas damondouglas

Labels
P2 task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@damondouglas