Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and types to ReadFrom/WriteToBigQuery. #31537

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Jun 7, 2024

As well as being good practice, this will give us better generated documentation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

As well as being good practice, this will give us better generated documentation.
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@robertwb robertwb changed the title Add types to ReadFrom/WriteToBigQuery. Add documentation and types to ReadFrom/WriteToBigQuery. Jun 7, 2024
@robertwb
Copy link
Contributor Author

R: @ahmedabu98

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but LGTM

sdks/python/apache_beam/yaml/yaml_io.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/yaml/yaml_io.py Outdated Show resolved Hide resolved
Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
@robertwb
Copy link
Contributor Author

Thanks, and +1 to your suggestions.

@robertwb robertwb merged commit 814cc8d into apache:master Jun 10, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants