-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: permission denied in the docker image #4464
base: master
Are you sure you want to change the base?
Conversation
Could you help to review this PR? @shoothzj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bump |
@lhotari Would you please take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not great that /opt/bookkeeper is required to be writable, but that issue could be handled separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the build should be a multi-staged one. Otherwise chmod/chown operations could increase the resulting image size significantly because changing the ownership or access bits makes a copy of the file.
c6c925d
to
f393914
Compare
@lhotari Your review result has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work!
Fix #4461
Motivation
$BK_USER
has been added to the image, we should use this user to run the image.You can try this command to verify this PR.
Changes
$BK_USER
with the grouproot
to run the image.ZK_SHELL_HOME
to set the zk-shell home to writing.zk-shell
file toBK_HOME/data
, notBK_HOME
.