Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus buildMode should sort JVM before Native execution #5001

Closed
lsergio opened this issue Dec 20, 2023 · 6 comments · Fixed by #5070
Closed

Quarkus buildMode should sort JVM before Native execution #5001

lsergio opened this issue Dec 20, 2023 · 6 comments · Fixed by #5070
Labels
area/quarkus Related to the Quarkus runtime good first issue Does not require full understanding of the codebase

Comments

@lsergio
Copy link
Contributor

lsergio commented Dec 20, 2023

What happened?

I created an Integration and specified that both the jvm and native builds should run:

traits:
    quarkus:
      buildMode:
      - native
      - jvm

As I understood, as soon as the jvm build is complete, the integration pod should start, and then be replaced when the native build is complete.

However, the integration pod only started after both builds finished.

Steps to reproduce

  1. Create an Integration that specifies both buildModes
  2. Wait for the jvm build to finish
  3. Check that the integration does not start
  4. Wait for native build to finish
  5. Check that now it started

Relevant log output

No response

Camel K version

2.1.0 and 2.2.0-nightly

@lsergio lsergio added the kind/bug Something isn't working label Dec 20, 2023
@squakez
Copy link
Contributor

squakez commented Dec 21, 2023

I think this could be because of the execution order provided. Try switching order (jvm, then native) and see if it solves. If that's the case we either need to document this or to add a little tweak to make sure jvm is always coming before native. Please, check if changing the order solves.

@squakez squakez added status/waiting-for-feedback Needs some feedback area/quarkus Related to the Quarkus runtime labels Dec 21, 2023
@lsergio
Copy link
Contributor Author

lsergio commented Dec 21, 2023

@squakez Indeed, switching the order fixed the issue. thanks!

@squakez
Copy link
Contributor

squakez commented Dec 21, 2023

I'll keep this open as a future improvement.

@squakez squakez removed kind/bug Something isn't working status/waiting-for-feedback Needs some feedback labels Dec 21, 2023
@squakez squakez changed the title buildMode behavior not working as expected when using jvm and native builds simultaneously Quarkus buildMode should sort JVM before Native execution Dec 21, 2023
@squakez
Copy link
Contributor

squakez commented Dec 22, 2023

BTW, feel free to contribute. This one looks quite simple to do.

@squakez squakez added the good first issue Does not require full understanding of the codebase label Dec 22, 2023
@michalvavrik
Copy link
Contributor

BTW, feel free to contribute. This one looks quite simple to do.

I'll try if not urgent. Can't do it in a few days.

@squakez
Copy link
Contributor

squakez commented Jan 10, 2024

BTW, feel free to contribute. This one looks quite simple to do.

I'll try if not urgent. Can't do it in a few days.

Sure, there's no hurry to have this completed. Let us know if you need any support while developing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quarkus Related to the Quarkus runtime good first issue Does not require full understanding of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants