JAVA-3143: Extend driver vector support to arbitrary subtypes and fix handling of variable length types (OSS C* 5.0) #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he.cassandra.db.marshal.FloatType,3)")
|
This branch is on top of #1931 |
SiyaoIsHiding
commented
Sep 3, 2024
| @@ -196,7 +233,8 @@ public int hashCode() { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return Iterables.toString(this.list); | |||
| TypeCodec<T> subcodec = CodecRegistry.DEFAULT.codecFor(list.get(0)); | |||
There was a problem hiding this comment.
Previously we promised that CqlVector.from should mirror CqlVector.toString. CqlVector.from has access to a subtype codec and expects some values to be single-quoted, e.g. texts. Therefore, without this change to toString, a round-trip test like CqlVector.from(vector1.toString(), codec); will fail. However, fetching the default codec for the subtype looks like too much effort for something simple like toString.
| @@ -49,6 +50,7 @@ public class DefaultSelect implements SelectFrom, Select { | |||
| private final ImmutableList<Relation> relations; | |||
| private final ImmutableList<Selector> groupByClauses; | |||
| private final ImmutableMap<CqlIdentifier, ClusteringOrder> orderings; | |||
| private final Ann ann; | |||
There was a problem hiding this comment.
Shall we expose a getter like for other fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.