Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate cordova-plugin-whitelist #155

Closed
janpio opened this issue Nov 24, 2018 · 3 comments · May be fixed by #203
Closed

Investigate cordova-plugin-whitelist #155

janpio opened this issue Nov 24, 2018 · 3 comments · May be fixed by #203
Assignees
Labels

Comments

@janpio
Copy link
Member

janpio commented Nov 24, 2018

Why same name as normal plugin cordova-plugin-whitelist?
Where is this actually used and why?

@janpio janpio added question and removed question labels Nov 26, 2018
@janpio
Copy link
Member Author

janpio commented May 24, 2019

This could be a plugin to actually test cordova-plugin-whitelist. That doesn't have its own tests, so maybe someone forgot to move this over? Or it is a different type of test plugin that only works in context of mobilespec and not the testing plugin?

@janpio janpio self-assigned this May 28, 2019
@janpio
Copy link
Member Author

janpio commented May 28, 2019

Indeed a test plugin that could be moved over to the actual plugin, as it is for all the other plugins.

PR to add it to the plugin: apache/cordova-plugin-whitelist#38

We should probably remove it here when this is merged.

@janpio
Copy link
Member Author

janpio commented Jun 19, 2019

apache/cordova-plugin-whitelist#38 has been merged, whitelist plugin is running its own tests now.

We have to finish this on mobile-spec side now by merging #203 and thus closing #200

@janpio janpio closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant