AAR-232: (android) Camera plugin code cleanup - Part #2 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazems
commented
Feb 24, 2019
| @@ -18,34 +18,13 @@ Licensed to the Apache Software Foundation (ASF) under one | |||
| */ | |||
| package org.apache.cordova.camera; | |||
|
|
|||
hazems
commented
Feb 24, 2019
| @@ -87,13 +81,19 @@ Licensed to the Apache Software Foundation (ASF) under one | |||
|
|
|||
| private static final int JPEG = 0; // Take a picture of type JPEG | |||
| private static final int PNG = 1; // Take a picture of type PNG | |||
There was a problem hiding this comment.
Organizing hard coded literal strings.
hazems
commented
Feb 24, 2019
| //I have no idea what type of URI is being passed in | ||
| this.imageUri = new CordovaUri(Uri.parse(state.getString("imageUri"))); | ||
| this.imageUri = new CordovaUri(Uri.parse(state.getString(IMAGE_URI_KEY))); | ||
| } | ||
|
|
||
| this.callbackContext = callbackContext; | ||
| } | ||
|
|
There was a problem hiding this comment.
Fixing mis-formatted comment.
macdonst
approved these changes
Mar 1, 2019
|
Thanks @macdonst |
hazems
changed the title
hazems
changed the title
3 tasks
DavidWiesner
pushed a commit
to DavidWiesner/cordova-plugin-camera
that referenced
this pull request
Dec 7, 2021
(cherry picked from commit a13665d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
What testing has been done on this change?
Making sure that everything builds fine, also, run my own tests for Android Camera and all pass fine.
Checklist
(platform)if this change only applies to one platform (e.g.(android))