-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.0.0 iOS: EXIF and GPS location does not work for Camera or Gallery Selected Images #759
Comments
Hey @codeconsole, thanks for your work here. I've also been juggling this issue for years, and I want to add some more context to this issue to respectfully ask if it can be looked at by those with the power to merge things. The current environment:
I respect and want to thank the maintainers past and present. If the desire to fix this has gone or there's no bandwidth to do so, then just let us know. (@erisu, do you have any bandwidth to merge this PR) As I see it, if there is no bandwidth to get proper exif support here, then one way forward may be in Javascript: i.e. capture the location data externally and then add the exif data manually into the image in JS. But this won't help with exif on library photos, which this PR appears to solve. |
Bundle support was added in cordova android 9.0. Recommend 9.1 for bug fixes related to bundles. You can use build.json file or --packageType=bundle to build aab bundles. You don't need 10.x to build bundles. |
@breautekt Thanks for the correction. Sounds like a short-term path forward may be to use I'll give that a try and report back for the community. Update: 9.1 + the exif fork works for now as a workaround. |
@codeconsole I left feedback on the PR for more information. |
@erisu Thanks for the reply. The pull request is the changes from #525 which is from 2 years ago, but without the Android changes since I believe the Android version was fixed. I assumed that @ryaa 's #525 never got merged and was neglected because it went out of sync. #712 brought 525 in sync, but does not fully address all the issues. It is just @ryaa 's merged (iOS) branch which was the most working at the time. Which was still better than noting and worked better than what the original provided. Regarding the GSP information, I don't believe @ryaa 's adequately addresses it, nor can I confirm it working. In my opinion, it really just provides a solution for getting the exif info from the photos album which, again, is better than nothing. |
@erisu I can tell you 100% that this pull request fixes exif information being saved when choosing from photo library. Can you please merge it so we can at least have a somewhat working release? This has been broken for over 2 years. Wouldn't it be better to merge something that works rather than continuously releasing new versions of something broken? Perhaps it would encourage more people in the community to get involved and fix the rest of the plugin rather than feeling ignored and then switching to other platforms such as capacitor. At the very least, if you do not want the plugin to be fixed, update the documentation to state exif information is not supported and not available. |
Resolved by #712 |
This has been broken for years and either the documentation should be updated to not support it or a fix should be made.
This camera plugin seems to work fine:
https://github.com/remoorejr/cordova-plugin-camera-with-exif
Consider referencing it for a solution on how to solve this issue.
But this is a core plugin and should be fixed. Broken core plugins lead to a lot of people abandoning Cordova for other frameworks due to frustration.
I've created a sample app that demonstrates EXIF not working for Camera and Gallery.
https://github.com/codeconsole/exiftest
I've even created a pull request fix from other users contributions:
#712
This fix only fixes the Gallery and still results in the camera not showing Exif data.
I highly recommend at least merging the pull request if there is no desire left in the project to fix this plugin. At least it will partially work.
The text was updated successfully, but these errors were encountered: