Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update cordovaDependencies given new plugin version? #298

Closed
ath0mas opened this issue Feb 20, 2021 · 2 comments · Fixed by #299
Closed

Should update cordovaDependencies given new plugin version? #298

ath0mas opened this issue Feb 20, 2021 · 2 comments · Fixed by #299
Labels
Milestone

Comments

@ath0mas
Copy link
Contributor

ath0mas commented Feb 20, 2021

"cordovaDependencies": {
"2.0.0": {
"cordova": ">100"
}
}

After recent bump to 2.0.0-dev, it seems when 2.0.0 will be released the cordovaDependencies block refering to 2.0.0 will apply and force cordova to out of normal version. 🤔

⇒ Should this cordovaDependencies block be updated?

@breautek
Copy link
Contributor

Yes.

Because this plugin is in the process of being revived from previously a deprecated state... I would personally be in favour of declaring that this plugin only works on cordova >= 10 (current cordova cli release). So the cordovaDependencies block should look something like:

{ 
    "2.0.0": { 
         "cordova": ">=10" 
    },
    "3.0.0": {
         "cordova": ">100" 
    }
} 

@ath0mas
Copy link
Contributor Author

ath0mas commented Feb 20, 2021

@breautek thanks for your answer

Feel free to confirm this suggested change in the days or months to come and I'll add corresponding commit to PR #299

    "2.0.0": { 
         "cordova": ">=10" 
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants