CB-14197: (all) Fix for createFile/writeFile silently failing to send 'write' action #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileWriter is missing the require('./FileReader') module causing the
native FileReader to be used instead of the FileReader proxy.
Oddly this does not happen everytime, but I could consistently
reproduce the issue when running subsequent `cordova run android`
commands on an Ionic app running in a 7.1.1 Android Emulator.
|
@stevengill Would you be able to review this PR for me? |
You may want to ping dev@cordova.apache.org to get a review and a possible merge. |
|
Thanks for the PR @wfairclough, good catch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileWriter is missing the require('./FileReader') module causing the
native FileReader to be used instead of the FileReader proxy.
Oddly this does not happen everytime, but I could consistently
reproduce the issue when running subsequent
cordova run androidcommands on an Ionic app running in a 7.1.1 Android Emulator.
Platforms affected
All Platforms
Witnessed on Android
What does this PR do?
Adds a missing require statement to ensure the correct FileReader is used
What testing has been done on this change?
Since this issue was very difficult to reproduce it was pretty hard to test. We found
that this issue occurs most frequently when running our ionic app in the Android
emulator and then run
ionic cordova run androidmultiple times to reinstall the appbefore we consistently saw the issue. With the changes from this PR we stopped
seeing the issue entirely.
I believe this PR will also fix the issue reported on the ionic-native project:
danielsogl/awesome-cordova-plugins#2067
npm testpassesChecklist