Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-12941: update typings #267

Merged
merged 2 commits into from
Oct 2, 2018
Merged

CB-12941: update typings #267

merged 2 commits into from
Oct 2, 2018

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Apr 22, 2018 •
edited by janpio
Loading

Platforms affected

n/a - development with TypeScript

What does this PR do?

Updates the typings to match the latest published version on DefinitelyTyped.
See DefinitelyTyped/DefinitelyTyped#17192 and https://stackoverflow.com/q/42095516/1902598

What testing has been done on this change?

Project compiles again ;)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • n/a: Added automated test coverage as appropriate for this change.

fixes #300

@timbru31 timbru31 mentioned this pull request Apr 22, 2018
Closed
2 tasks
@timbru31
Copy link
Member Author

timbru31 commented May 2, 2018

The Jenkins failure (https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/369798189) seems unrelated.

@janpio janpio added the bug label Sep 17, 2018
@timbru31
Copy link
Member Author

I've rebased the PR - hopefully TravisCI will complete successfully 👍

@janpio
Copy link
Member

janpio commented Sep 18, 2018

Nope, seems our tests here are just borked. Someone will have to fix those in master properly first. Now that we are aware, this of course can be considered when reviewing this PR.

@HarelM HarelM mentioned this pull request Sep 20, 2018
Closed
@janpio
removed version in types
31c9b46 
nobody will keep those updated...
@janpio janpio merged commit a0c267f into apache:master Oct 2, 2018
@timbru31 timbru31 deleted the feature/update-typings branch October 2, 2018 11:30
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typings does not export cordova.InAppBrowser.open
2 participants
@timbru31 @janpio