Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14061: (android) comply with RFC 3986 for custom URL scheme handling #269

Merged

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented May 2, 2018

Platforms affected

Android

What does this PR do?

This fixes a small regression of #263 to allow more custom URL schemes for android (see comment #263 (comment))

What testing has been done on this change?

Manual testing with a custom URL scheme: staging+d2d

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@timbru31 timbru31 force-pushed the fix/CB-14061-handle-more-url-schemes branch from ccaa628 to f57ede9 Compare May 2, 2018 18:22
@timbru31 timbru31 changed the title fix(CB-14061): comply with RFC 3986 for custom URL scheme handling CB-14061: (android) comply with RFC 3986 for custom URL scheme handling May 2, 2018
@panoti
Copy link

panoti commented May 11, 2018

this PR is necessary for ionic using with auth0. Example code Auth0 use PACKAGE_ID as URL_SCHEME ( <variable name="URL_SCHEME" value="com.auth0.ionic" />).

@timbru31
Copy link
Member Author

Travis failure (https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/374068004) seems unrelated.

@jcesarmobile jcesarmobile merged commit 26cf6e4 into apache:master May 19, 2018
@timbru31 timbru31 deleted the fix/CB-14061-handle-more-url-schemes branch October 17, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants