Fix test spec.5 to close inappbrowser after loadstop event #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
all platforms (but test only)
Motivation and Context
The spec 'inappbrowser.spec.5 should support exit event' in
cordova-plugin-inappbrowser-tests.tests
is testing exit event.But before this PR,
close
method may be fired before InAppBrowser opens a URL.Then cordova-windows, the corresponding test (spec.6) sometimes fails, the InAppBrowser is kept opened.
Then the next spec (spec.6) fails.
This PR is to fix this issue.
Description
Instead of calling
close()
method synchronously,I call
close()
method in callback ofloadstop
event.Testing
With the help of cordova-mobile-spec, I confirmed all cordova-plugin-inappbrowser-tests.tests work well.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)