Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iphone 10 notch issue in inappbrowser #525

Closed
2 of 3 tasks
ghost opened this issue Aug 21, 2019 · 2 comments
Closed
2 of 3 tasks

iphone 10 notch issue in inappbrowser #525

ghost opened this issue Aug 21, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 21, 2019

Bug Report

when inapp browser is loaded in iphone x status bar height is only 20px as it is hard coded

What is expected to happen?

if the view is loaded in the browser set status bar height must be set to 46px instead of 20px(which is hard coded in plugin file cdvuiinappbrowser.m)

What does actually happen?

it is has been set to 20px and displaying a half greyed screen it can be made to zero by changing "statusbar.height to 0 in viewdidload(){}" in plugin but changing plugin is not coding format

Information

Command or Code

Environment, Platform, Device

Version information

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@NiklasMerz
Copy link
Member

NiklasMerz commented Sep 5, 2019

See #301 (comment)

A PR needs to be done to add this.

@jcesarmobile
Copy link
Member

closing as duplicate of #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants