Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect global settings in settings.json, then the local ones in launch.json #1127

Open
scholarsmate opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working configuration issues related to configuration data editor Issues related to the Data Editor capability extension Issues releated to the VSCode Extension javascript Pull requests that update Javascript code typescript
Milestone

Comments

@scholarsmate
Copy link
Contributor

Port 9000 is the default port for the Ωedit server that powers the Data Editor. The problem is that I have another service that is running on port 9000, so I need to change the port that the Ωedit server runs on. I want to use port 9001 for that. I think the most intuitive place to persist that variable is in a global settings.json that is configurable at the extension level.

Screenshot 2024-11-12 at 12 12 35 PM Screenshot 2024-11-12 at 12 13 29 PM

Clicking on Edit in settings.json allows me to change the port, but that setting seems to be ignored. It would be good to have that work as it will allow users to configure a different port and use the Data Editor without requiring a .vscode/launch.json in their repository.

The workaround for now is to set the port in launch.json like so:

           "dataEditor": {
                "port": 9001,
                "logging": {
                    "file": "${workspaceFolder}/dataEditor-${omegaEditPort}.log",
                    "level": "info"
                }
            },

Having it respect the global settings, then allow them to be overridden in a local launch.json would be better.

@scholarsmate scholarsmate added bug Something isn't working javascript Pull requests that update Javascript code typescript data editor Issues related to the Data Editor capability configuration issues related to configuration extension Issues releated to the VSCode Extension labels Nov 12, 2024
@scholarsmate scholarsmate added this to the 1.4.1 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working configuration issues related to configuration data editor Issues related to the Data Editor capability extension Issues releated to the VSCode Extension javascript Pull requests that update Javascript code typescript
Projects
Status: Todo
Development

No branches or pull requests

1 participant