Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CometSortMergeJoin statistics #303

Closed
planga82 opened this issue Apr 22, 2024 · 0 comments · Fixed by #304
Closed

Improve CometSortMergeJoin statistics #303

planga82 opened this issue Apr 22, 2024 · 0 comments · Fixed by #304
Labels
enhancement New feature or request

Comments

@planga82
Copy link
Contributor

What is the problem the feature request solves?

Add all statistics SortMergeJoinExec datafusion node provides.

Describe the potential solution

Override metrics map in CometSortMergeJoin to provide all available metrics

Additional context

Current metrics:

output_rows
Elapsed_compute

All available metrics

    /// Total time for joining probe-side batches to the build-side batches
    join_time: metrics::Time,
    /// Number of batches consumed by this operator
    input_batches: metrics::Count,
    /// Number of rows consumed by this operator
    input_rows: metrics::Count,
    /// Number of batches produced by this operator
    output_batches: metrics::Count,
    /// Number of rows produced by this operator
    output_rows: metrics::Count,   
    /// Peak memory used for buffered data.
    /// Calculated as sum of peak memory values across partitions
    peak_mem_used: metrics::Gauge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant