Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TryCast expression in Spark 3.2 and 3.3 #374

Closed
Tracked by #286
andygrove opened this issue May 2, 2024 · 1 comment · Fixed by #416
Closed
Tracked by #286

Add support for TryCast expression in Spark 3.2 and 3.3 #374

andygrove opened this issue May 2, 2024 · 1 comment · Fixed by #416
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Spark 3.2 and 3.3 has a TryCast expression and Spark 3.4 removed it and added an evalMode parameter to the Cast expression.

We do not support the TryCast expression and should add support. This was missed until now because CometCastSuite calls checkSparkAnswer instead of checkSparkAnswerAndOperator.

Describe the potential solution

No response

Additional context

No response
@andygrove andygrove added the enhancement New feature or request label May 2, 2024
@andygrove andygrove mentioned this issue May 2, 2024
Open
37 tasks
@vaibhawvipul
Copy link
Contributor

I am working on this one.

@vaibhawvipul vaibhawvipul mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for TryCast expression in Spark 3.2 and 3.3 vaibhawvipul/datafusion-comet
2 participants
@andygrove @vaibhawvipul