Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rs build fails for datafusion-proto 37.0.0 #10163

Closed
alamb opened this issue Apr 21, 2024 · 2 comments · Fixed by #10254
Closed

docs.rs build fails for datafusion-proto 37.0.0 #10163

alamb opened this issue Apr 21, 2024 · 2 comments · Fixed by #10254
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Apr 21, 2024

Describe the bug

Apparently the build failed for https://docs.rs/crate/datafusion-proto/latest

Screenshot 2024-04-21 at 1 04 04 PM

The build has a log
https://docs.rs/crate/datafusion-proto/37.0.0/builds/1179419

https://docs.rs/crate/datafusion-proto/37.0.0/builds/1179419/x86_64-unknown-linux-gnu.txt

# rustc version
rustc 1.79.0-nightly (385fa9d84 2024-04-04)
# docs.rs version
docsrs 0.6.0 (42f2c842 2024-04-05)

# build log
[INFO] running `Command { std: "docker" "create" "-v" "/home/cratesfyi/workspace/builds/datafusion-proto-37.0.0/target:/opt/rustwide/target:rw,Z" "-v" "/home/cratesfyi/workspace/builds/datafusion-proto-37.0.0/source:/opt/rustwide/workdir:ro,Z" "-v" "/home/cratesfyi/workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/home/cratesfyi/workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "DOCS_RS=1" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "6442450944" "--cpus" "6" "--user" "1001:1001" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "rustdoc" "--lib" "-Zrustdoc-map" "--config" "build.rustdocflags=[\"--cfg\", \"docsrs\", \"-Z\", \"unstable-options\", \"--emit=invocation-specific\", \"--resource-suffix\", \"-20240404-1.79.0-nightly-385fa9d84\", \"--static-root-path\", \"/-/rustdoc.static/\", \"--cap-lints\", \"warn\", \"--extern-html-root-takes-precedence\"]" "--offline" "-Zunstable-options" "--config=doc.extern-map.registries.crates-io=\"https://docs.rs/{pkg_name}/{version}/x86_64-unknown-linux-gnu\"" "-Zrustdoc-scrape-examples" "-j6" "--target" "x86_64-unknown-linux-gnu", kill_on_drop: false }`
[INFO] [stdout] afc2ab1a717fcddc18e7dcb057f4d3be9d2b033a86d67ca3c1a799101a944db3
[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] running `Command { std: "docker" "start" "-a" "afc2ab1a717fcddc18e7dcb057f4d3be9d2b033a86d67ca3c1a799101a944db3", kill_on_drop: false }`
[INFO] [stderr] warning: target filter specified, but no targets matched; this is a no-op
[INFO] [stderr]  Documenting datafusion-proto v37.0.0 (/opt/rustwide/workdir)
[INFO] [stderr] error[E0432]: unresolved import `generated::datafusion`
[INFO] [stderr]    --> src/lib.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 | pub use generated::datafusion as protobuf;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `datafusion` in `generated`
[INFO] [stderr]     |
[INFO] [stderr] note: found an item that was configured out
[INFO] [stderr]    --> src/generated/mod.rs:21:9
[INFO] [stderr]     |
[INFO] [stderr] 21  | pub mod datafusion {
[INFO] [stderr]     |         ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0432`.
[INFO] [stderr] error: could not document `datafusion-proto`
[INFO] running `Command { std: "docker" "inspect" "afc2ab1a717fcddc18e7dcb057f4d3be9d2b033a86d67ca3c1a799101a944db3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "afc2ab1a717fcddc18e7dcb057f4d3be9d2b033a86d67ca3c1a799101a944db3", kill_on_drop: false }`
[INFO] [stdout] afc2ab1a717fcddc18e7dcb057f4d3be9d2b033a86d67ca3c1a799101a944db3

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@alamb alamb added the bug Something isn't working label Apr 21, 2024
@alamb alamb changed the title docs.rs build fails for datafusion-proto docs.rs build fails for datafusion-proto 37.0.0 Apr 21, 2024
@alamb alamb added the help wanted Extra attention is needed label Apr 25, 2024
@alamb
Copy link
Contributor Author

alamb commented Apr 26, 2024

Looks like the problem actually exists on 36.0.0 as well: https://docs.rs/crate/datafusion-proto/36.0.0/builds/1133246

It seems like the issue is that this module is not enabled in docsrs:

https://github.com/apache/datafusion/blame/main/datafusion/proto/src/generated/mod.rs#L20

Which looks like it came in #3580 (but was before we vendored (aka checked in the code)). I think the solution is to just comment out that define

@alamb
Copy link
Contributor Author

alamb commented May 21, 2024

FWIW it seems to be working on 38.0.0: https://docs.rs/datafusion-proto/latest/datafusion_proto/

Screenshot 2024-05-21 at 3 47 44 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant