Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DataPtr trait and use Arc::ptr_eq directly #10377

Closed
intoraw opened this issue May 4, 2024 · 0 comments · Fixed by #10378
Closed

Remove DataPtr trait and use Arc::ptr_eq directly #10377

intoraw opened this issue May 4, 2024 · 0 comments · Fixed by #10378
Labels
enhancement New feature or request

Comments

@intoraw
Copy link
Contributor

intoraw commented May 4, 2024

Is your feature request related to a problem or challenge?

rust-lang/rust#106450
Arc::ptr_eq compares the underlying pointer without metadata, it should be safe to use Arc::ptr_eq now.

Describe the solution you'd like

Remove DataPtr trait and use Arc::ptr_eq directly.

Describe alternatives you've considered

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove DataPtr trait since Arc::ptr_eq ignores pointer metadata intoraw/datafusion
1 participant
@intoraw