Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow bug in FACTORIAL scalar function (found by SQLancer) #11074

Closed
2010YOUY01 opened this issue Jun 23, 2024 · 1 comment · Fixed by #11134
Closed

Overflow bug in FACTORIAL scalar function (found by SQLancer) #11074

2010YOUY01 opened this issue Jun 23, 2024 · 1 comment · Fixed by #11134
Assignees
Labels
bug Something isn't working

Comments

@2010YOUY01
Copy link
Contributor

Describe the bug

The following statement should return an error instead of directly crash

> select FACTORIAL(350943270);
thread 'main' panicked at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/iter/traits/accum.rs:149:1:
attempt to multiply with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Found by very initial implementation of SQLancer #11030

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@2010YOUY01 2010YOUY01 added the bug Something isn't working label Jun 23, 2024
@LorrensP-2158466
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants