Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lpad udf by using a GenericStringBuilder #11984

Closed
Omega359 opened this issue Aug 14, 2024 · 1 comment · Fixed by #11987
Closed

Improve lpad udf by using a GenericStringBuilder #11984

Omega359 opened this issue Aug 14, 2024 · 1 comment · Fixed by #11987
Assignees
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Is your feature request related to a problem or challenge?

As noted in the discussion in #11941 (comment) it looks like the performance of the lpad udf may be improved a bit by using a GenericStringBuilder instead of creating a string every time.

As well, as noted in #11941 (comment) there may be room for improvement with the general code.

Describe the solution you'd like

lpad udf updated to use a GenericStringBuilder and a benchmark added to showcase whether it improves performance or not

Describe alternatives you've considered

No response

Additional context

No response

@Omega359 Omega359 added the enhancement New feature or request label Aug 14, 2024
@Omega359
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant